cmake: update standalone example minimum version - #416
Merged
EugenioCollado merged 1 commit intoJul 6, 2026
Conversation
Generated-by: OpenAI Codex Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmake_minimum_required(VERSION 2.8.12)to3.5.0Why
CMake 4 removed compatibility with projects that request versions older than 3.5, so these standalone CMakeLists fail before configuration can proceed. The top-level project already requires CMake 3.16, and nearby standalone examples/tests in this repo already use 3.5.0.
Testing
git diff --checkrg -n "cmake_minimum_required\(VERSION 2\.8\.12|cmake_minimum_required\(VERSION 3\.[0-4]" examples testgit ls-files --eol $(git diff --name-only HEAD~1..HEAD)Not run: CMake configure/build, because this local Windows environment does not have CMake or a C/C++ compiler installed.